Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use a single 'provider_type' key for storing discussion provider type in course [BACKPORT][BB-9323] #722

Merged

Conversation

0x29a
Copy link
Member

@0x29a 0x29a commented Dec 23, 2024

Backports openedx#36039

… type in course

Both 'provider' and 'provider_type' have been used for storing the discussion provider type in course 'discussions_settings' field, there are some places in the code checking for 'provider' and others checking for 'provider_type', in some cases this can cause a bug where it doesn't detect the correct provider which causes discussion settings not being copied correctly when a course is cloned.

This change prioritises the `provider_type` setting over `provider` and reads `provider` only as a fallback. The `provider` setting is now made read-only just for backwards-compatibility, to avoid confusion.

(cherry picked from commit cbddd4e)
@xitij2000 xitij2000 merged commit 8612f2a into opencraft-release/redwood.1 Dec 24, 2024
77 checks passed
@xitij2000 xitij2000 deleted the backport-fix-discussion-clone branch December 24, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants